Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Download asc from artifact store specified in spec #21488

Merged
merged 4 commits into from
Oct 5, 2020
Merged

[Ingest Manager] Download asc from artifact store specified in spec #21488

merged 4 commits into from
Oct 5, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Oct 2, 2020 •
edited
Loading

What does this PR do?

For asc atrifact name was hardcoded to beats, which caused issues with endpoint

Why is it important?

So endpoint can be securely downloaded.
Fixes: #21485

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug Team:Ingest Management Ingest Management:beta2 Group issues for ingest management beta2 labels Oct 2, 2020
@michalpristas michalpristas self-assigned this Oct 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 2, 2020
@michalpristas michalpristas marked this pull request as draft October 2, 2020 16:37
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 2, 2020 •
edited by jenkins-beats-ci bot
Loading

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21488 updated]

  • Start Time: 2020-10-05T06:52:28.956+0000

  • Duration: 30 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 691
Skipped 2
Total 693

Steps errors

Expand to view the steps failures

  • Name: Extract

    • Description: tar -xpf source.tgz

    • Duration: 1 min 39 sec

    • Start Time: 2020-10-05T07:20:53.964+0000

    • log

  • Name: Error signal

    • Description: untar: step failed with error script returned exit code 1

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-05T07:21:33.067+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-10-05T07:21:55.906Z]   Version:          0.18.0
[2020-10-05T07:21:55.906Z]   GitCommit:        fec3683
[2020-10-05T07:21:55.906Z] Unable to find image 'alpine:3.4' locally
[2020-10-05T07:21:56.477Z] 3.4: Pulling from library/alpine
[2020-10-05T07:21:56.477Z] c1e54eec4b57: Pulling fs layer
[2020-10-05T07:21:56.738Z] c1e54eec4b57: Verifying Checksum
[2020-10-05T07:21:56.738Z] c1e54eec4b57: Download complete
[2020-10-05T07:21:57.021Z] c1e54eec4b57: Pull complete
[2020-10-05T07:21:57.021Z] Digest: sha256:b733d4a32c4da6a00a84df2ca32791bb03df95400243648d8c539e7b4cce329c
[2020-10-05T07:21:57.021Z] Status: Downloaded newer image for alpine:3.4
[2020-10-05T07:21:58.731Z] + python .ci/scripts/pre_archive_test.py
[2020-10-05T07:21:58.731Z] Copy ./x-pack/elastic-agent/build into build/x-pack/elastic-agent/build
[2020-10-05T07:21:58.742Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21488/src/github.com/elastic/beats/build
[2020-10-05T07:21:58.773Z] WARNING: Unknown parameter(s) found for class type 'hudson.tasks.junit.pipeline.JUnitResultsStep': id,stashedTestReports
[2020-10-05T07:21:58.777Z] Recording test results
[2020-10-05T07:21:59.703Z] Stashed 1 file(s)
[2020-10-05T07:21:59.715Z] Archiving artifacts
[2020-10-05T07:22:00.063Z] + python .ci/scripts/search_system_tests.py
[2020-10-05T07:22:00.122Z] [INFO] system-tests=''. If no empty then let's create a tarball
[2020-10-05T07:22:00.465Z] Client: Docker Engine - Community
[2020-10-05T07:22:00.465Z]  Version:           19.03.13
[2020-10-05T07:22:00.465Z]  API version:       1.40
[2020-10-05T07:22:00.465Z]  Go version:        go1.13.15
[2020-10-05T07:22:00.465Z]  Git commit:        4484c46d9d
[2020-10-05T07:22:00.465Z]  Built:             Wed Sep 16 17:02:36 2020
[2020-10-05T07:22:00.465Z]  OS/Arch:           linux/amd64
[2020-10-05T07:22:00.465Z]  Experimental:      false
[2020-10-05T07:22:00.465Z] 
[2020-10-05T07:22:00.465Z] Server: Docker Engine - Community
[2020-10-05T07:22:00.465Z]  Engine:
[2020-10-05T07:22:00.465Z]   Version:          19.03.13
[2020-10-05T07:22:00.465Z]   API version:      1.40 (minimum version 1.12)
[2020-10-05T07:22:00.465Z]   Go version:       go1.13.15
[2020-10-05T07:22:00.465Z]   Git commit:       4484c46d9d
[2020-10-05T07:22:00.465Z]   Built:            Wed Sep 16 17:01:06 2020
[2020-10-05T07:22:00.465Z]   OS/Arch:          linux/amd64
[2020-10-05T07:22:00.465Z]   Experimental:     false
[2020-10-05T07:22:00.465Z]  containerd:
[2020-10-05T07:22:00.465Z]   Version:          1.3.7
[2020-10-05T07:22:00.465Z]   GitCommit:        8fba4e9a7d01810a393d5d25a3621dc101981175
[2020-10-05T07:22:00.465Z]  runc:
[2020-10-05T07:22:00.465Z]   Version:          1.0.0-rc10
[2020-10-05T07:22:00.465Z]   GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
[2020-10-05T07:22:00.465Z]  docker-init:
[2020-10-05T07:22:00.465Z]   Version:          0.18.0
[2020-10-05T07:22:00.465Z]   GitCommit:        fec3683
[2020-10-05T07:22:09.811Z] [INFO] unstashV2: JOB_GCS_BUCKET is set. bucket param got precedency instead.
[2020-10-05T07:22:09.821Z] [INFO] unstashV2: JOB_GCS_CREDENTIALS is set. credentialsId param got precedency instead.
[2020-10-05T07:22:09.887Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs://beats-ci-temp/Beats/beats/PR-21488-4/source/source.tgz
[2020-10-05T07:22:09.914Z] [Google Cloud Storage Plugin] Downloading: Beats/beats/PR-21488-4/source/source.tgz to local path: /var/lib/jenkins/workspace/Beats_beats_PR-21488/source.tgz
[2020-10-05T07:22:22.885Z] + tar --version
[2020-10-05T07:22:23.187Z] + tar -xpf source.tgz
[2020-10-05T07:22:35.767Z] + rm source.tgz
[2020-10-05T07:22:35.871Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21488/src/github.com/elastic/beats
[2020-10-05T07:22:35.880Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21488/src/github.com/elastic/beats/uncategorized-1601882204344
[2020-10-05T07:22:35.928Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-21488/src/github.com/elastic/beats/x-pack-elastic-agent-build-1601882519534
[2020-10-05T07:22:36.272Z] + cat
[2020-10-05T07:22:36.272Z] + /usr/local/bin/runbld ./runbld-test-reports --job-name elastic+beats+pull-request
[2020-10-05T07:22:36.272Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-10-05T07:22:42.887Z] runbld>>> runbld started
[2020-10-05T07:22:42.887Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-10-05T07:22:44.811Z] runbld>>> The following profiles matched the job 'elastic+beats+pull-request' in order of occurrence in the config (last value wins).
[2020-10-05T07:22:44.811Z] runbld>>> Matches in the system config:
[2020-10-05T07:22:44.811Z] runbld>>> - Matched ^elastic\+beats
[2020-10-05T07:22:44.811Z] runbld>>> - Matched ^elastic\+beats\+pull-request
[2020-10-05T07:22:46.204Z] runbld>>> Debug logging enabled.
[2020-10-05T07:22:46.204Z] runbld>>> Storing result
[2020-10-05T07:22:46.204Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-10-05T07:22:46.204Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20201005072245-4E410BDE
[2020-10-05T07:22:46.204Z] runbld>>> Adding system facts.
[2020-10-05T07:22:47.600Z] runbld>>> Adding vcs info for the latest commit:  34a9ec9c5d0475eeea6477ca4a4b430aa91a36b1
[2020-10-05T07:22:47.600Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-10-05T07:22:47.600Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-10-05T07:22:47.600Z] + echo 'Processing JUnit reports with runbld...'
[2020-10-05T07:22:47.600Z] Processing JUnit reports with runbld...
[2020-10-05T07:22:47.863Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-10-05T07:22:47.863Z] runbld>>> DURATION: 30ms
[2020-10-05T07:22:47.863Z] runbld>>> STDOUT: 40 bytes
[2020-10-05T07:22:47.863Z] runbld>>> STDERR: 49 bytes
[2020-10-05T07:22:47.863Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-10-05T07:22:47.863Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-21488
[2020-10-05T07:22:48.814Z] runbld>>> Storing build metadata: 
[2020-10-05T07:22:48.814Z] runbld>>> Adding test report.
[2020-10-05T07:22:48.814Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-21488/src/github.com/elastic/beats
[2020-10-05T07:22:49.392Z] runbld>>> Found 1 test output files
[2020-10-05T07:22:49.967Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 693 Skipped: 0
[2020-10-05T07:22:49.967Z] runbld>>> Storing result
[2020-10-05T07:22:49.967Z] runbld>>> FAILURES: 0
[2020-10-05T07:22:50.231Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-10-05T07:22:50.231Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20201005072245-4E410BDE
[2020-10-05T07:22:50.494Z] runbld>>> Email notification disabled by environment variable.
[2020-10-05T07:22:50.494Z] runbld>>> Slack notification disabled by environment variable.
[2020-10-05T07:22:56.366Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-21488
[2020-10-05T07:22:56.578Z] [INFO] getVaultSecret: Getting secrets
[2020-10-05T07:22:56.657Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-10-05T07:22:57.267Z] + chmod 755 generate-build-data.sh
[2020-10-05T07:22:57.267Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21488/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21488/runs/4 FAILURE 1828049
[2020-10-05T07:22:57.267Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21488/runs/4/steps/?limit=10000 -o steps-info.json
[2020-10-05T07:22:57.818Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21488/runs/4/tests/?status=FAILED -o tests-errors.json
[2020-10-05T07:22:57.818Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-21488/runs/4/log/ -o pipeline-log.txt

@michalpristas
Copy link
Contributor Author

michalpristas commented Oct 2, 2020 •
edited
Loading

tested on darwin and windows
test run:

  1. package windows artifact of agent
  2. unpack
  3. remove content of data/elastic-agent-{hash}/download directory
  4. enroll and run
{"log.level":"debug","@timestamp":"2020-10-02T17:37:35.090Z","log.origin":{"file.name":"operation/operator.go","file.line":250},"message":"operator is looking for endpoint-security--8.0.0-SNAPSHOT in app collection: map[]","ecs.version":"1.5.0"}
{"log.level":"debug","@timestamp":"2020-10-02T17:37:35.090Z","log.origin":{"file.name":"operation/operator.go","file.line":230},"message":"running operation 'retryable block: operation-fetch operation-verify' for endpoint-security.8.0.0-SNAPSHOT","ecs.version":"1.5.0"}
{"log.level":"debug","@timestamp":"2020-10-02T17:37:35.090Z","log.origin":{"file.name":"operation/operation_retryable.go","file.line":83},"message":"running operation 'operation-fetch' of the block 'retryable block: operation-fetch operation-verify'","ecs.version":"1.5.0"}
{"log.level":"info","@timestamp":"2020-10-02T17:37:39.625Z","log.origin":{"file.name":"operation/operation_fetch.go","file.line":75},"message":"operation 'operation-fetch' downloaded endpoint-security.8.0.0-SNAPSHOT into C:\\a\\ee\\data\\elastic-agent-289207\\downloads\\endpoint-security-8.0.0-SNAPSHOT-windows-x86_64.zip","ecs.version":"1.5.0"}
{"log.level":"debug","@timestamp":"2020-10-02T17:37:39.625Z","log.origin":{"file.name":"operation/operation_retryable.go","file.line":83},"message":"running operation 'operation-verify' of the block 'retryable block: operation-fetch operation-verify'","ecs.version":"1.5.0"}
{"log.level":"debug","@timestamp":"2020-10-02T17:37:40.198Z","log.origin":{"file.name":"operation/operator.go","file.line":230},"message":"running operation 'operation-install' for endpoint-security.8.0.0-SNAPSHOT","ecs.version":"1.5.0"}
{"log.level":"debug","@timestamp":"2020-10-02T17:37:41.024Z","log.origin":{"file.name":"operation/operator.go","file.line":230},"message":"running operation 'operation-start' for endpoint-security.8.0.0-SNAPSHOT","ecs.version":"1.5.0"}

@michalpristas michalpristas marked this pull request as ready for review October 2, 2020 17:43
@ph ph requested a review from blakerouse October 5, 2020 11:48
blakerouse
blakerouse approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a mechanical fix of passing in the artifactName to the verifier. Looks good!

@michalpristas michalpristas merged commit eb119c9 into elastic:master Oct 5, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request Oct 5, 2020
@michalpristas
[Ingest Manager] Download asc from artifact store specified in spec (e…
6ce3b27 
…lastic#21488)

[Ingest Manager] Download asc from artifact store specified in spec (elastic#21488)
@michalpristas michalpristas mentioned this pull request Oct 5, 2020
Merged
6 tasks
michalpristas added a commit that referenced this pull request Oct 5, 2020
@michalpristas
[Ingest Manager] Download asc from artifact store specified in spec (#…
0b22a3c 
…21488) (#21523)

[Ingest Manager] Download asc from artifact store specified in spec (#21488)
v1v added a commit to v1v/beats that referenced this pull request Oct 5, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2016
07afe0b 
* upstream/master: (26 commits)
  [Ingest Manager] Send updating state (elastic#21461)
  [Filebeat][New Fileset] Cisco Umbrella support (elastic#21504)
  [Ingest Manager] Download asc from artifact store specified in spec (elastic#21488)
  Implementation of fileProspector (elastic#21479)
  [Metricbeat] Add latency config option into aws module (elastic#20875)
  Skip filestream flaky tests (elastic#21490)
  Ignore unsupported metrics in the azure module (elastic#21486)
  Do not run symlink tests on Windows (elastic#21472)
  Map `cloud.account.id` to azure sub id (elastic#21483)
  Add support for app_state metricset (elastic#20639)
  Include original error when metricbeat fails to connect with Kafka (elastic#21484)
  Prompt only when agent is already enrolled (elastic#21473)
  Fix leftover delpoyment example (elastic#21474)
  Bump version to ECS 1.6 in modules without ECS updates (elastic#21455)
  Clarify input type configuration options (elastic#19284)
  Increase index pattern size check to 10MiB (elastic#21487)
  Migrate S3 Input to Filebeat Input V2 (elastic#20005)
  [libbeat] Add configurable exponential backoff for disk queue write errors (elastic#21493)
  Revert "Revert "[JJBB] Set shallow cloning to 10 (elastic#21409)" (elastic#21447)" (elastic#21467)
  Fix format of debug messages in tlscommon (elastic#21482)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
bug Ingest Management:beta2 Group issues for ingest management beta2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Agent failing to download relevant beats when enrolled in Fleet
3 participants
@michalpristas @elasticmachine @blakerouse